This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb/gdb-7.10-branch] Prelimit number of bytes to read in "vFile:pread:"
- From: sergiodj+buildbot at redhat dot com
- To: gdb-testers at sourceware dot org
- Date: Wed, 19 Aug 2015 09:35:48 -0400
- Subject: [binutils-gdb/gdb-7.10-branch] Prelimit number of bytes to read in "vFile:pread:"
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 5e83dd6fb19ba25a89e321a0eb1373b3d3fc3930 ***
Author: Gary Benson <gbenson@redhat.com>
Branch: gdb-7.10-branch
Commit: 5e83dd6fb19ba25a89e321a0eb1373b3d3fc3930
Prelimit number of bytes to read in "vFile:pread:"
While handling "vFile:pread:" packets, gdbserver would read the
number of bytes requested regardless of whether this would fit
into the reply packet. gdbserver would then return a packet's
worth of data and discard the remainder. When accessing large
binaries GDB (via BFD) routinely makes large "vFile:pread:"
requests, resulting in gdbserver allocating large unnecessary
buffers and reading some portions of the file many times over.
This commit causes gdbserver to limit the number of bytes to be
read to a sensible maximum prior to allocating buffers and reading
data.
gdb/gdbserver/ChangeLog:
* hostio.c (handle_pread): Do not attempt to read more data
than hostio_reply_with_data can fit in a packet.
- Follow-Ups:
- Failures on RHEL-s390x-m64, branch gdb-7.10-branch
- Failures on Fedora-i686, branch gdb-7.10-branch
- Failures on Debian-s390x-native-gdbserver-m64, branch gdb-7.10-branch
- Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch gdb-7.10-branch
- Failures on AIX-POWER7-plain, branch gdb-7.10-branch
- Failures on Fedora-x86_64-native-gdbserver-m64, branch gdb-7.10-branch
- Failures on Fedora-s390x-m64, branch gdb-7.10-branch
- Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch gdb-7.10-branch
- Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-7.10-branch
- Failures on Debian-s390x-native-extended-gdbserver-m64, branch gdb-7.10-branch
- Failures on Fedora-ppc64be-cc-with-index, branch gdb-7.10-branch
- Failures on Fedora-ppc64be-m64, branch gdb-7.10-branch
- Failures on Debian-i686, branch gdb-7.10-branch
- Failures on Fedora-ppc64be-native-gdbserver-m64, branch gdb-7.10-branch
- Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch gdb-7.10-branch
- Failures on Debian-i686-native-gdbserver, branch gdb-7.10-branch
- Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch gdb-7.10-branch
- Failures on Fedora-ppc64le-cc-with-index, branch gdb-7.10-branch
- Failures on Fedora-ppc64le-native-gdbserver-m64, branch gdb-7.10-branch
- Failures on Debian-x86_64-native-extended-gdbserver-m64, branch gdb-7.10-branch
- Failures on Debian-x86_64-m64, branch gdb-7.10-branch