This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
Test results for commit 53cf2ee0d933ac4d95530555854a6f8d3cefc2e8 on branch master
- From: sergiodj at redhat dot com
- To: gdb-testers at sourceware dot org
- Date: Thu, 19 Feb 2015 11:07:52 -0500
- Subject: Test results for commit 53cf2ee0d933ac4d95530555854a6f8d3cefc2e8 on branch master
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 53cf2ee0d933ac4d95530555854a6f8d3cefc2e8 ***
Author: David Taylor <dtaylor@emc.com>
Branch: master
Commit: 53cf2ee0d933ac4d95530555854a6f8d3cefc2e8
[gdb/ax] small "setv" fix and documentation's adjustment.
gdb/doc/agentexpr.texi documents the "setv" opcode as follow:
@item @code{setv} (0x2d) @var{n}: @result{} @var{v}
Set trace state variable number @var{n} to the value found on the top
of the stack. The stack is unchanged, so that the value is readily
available if the assignment is part of a larger expression. The
handling of @var{n} is as described for @code{getv}.
The @item line is incorrect (and does not match with its
description), so this patch fixes it.
Additionally, in gdb/common/ax.def we find the line:
DEFOP (setv, 2, 0, 0, 1, 0x2d)
>From the comment earlier in the file:
Each line is of the form:
DEFOP (name, size, data_size, consumed, produced, opcode)
[...]
CONSUMED is the number of stack elements consumed.
PRODUCED is the number of stack elements produced.
which is saying that nothing is consumed and one item is produced.
Both should be 0 or both should be 1.
This patch sets them both to 1, which seems better since if nothing
is on the stack an error will occur.
gdb/ChangeLog:
* common/ax.def (setv): Fix consumed entry in setv DEFOP.
gdb/doc/ChangeLog:
* agentexpr.texi (Bytecode Descriptions): Fix summary line for setv.
Tested on x86_64-linux.
- Follow-Ups:
- Failures on Fedora-ppc64be-cc-with-index, branch master
- Failures on Fedora-ppc64be-native-gdbserver-m64, branch master
- Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master
- Failures on Fedora-x86_64-m32, branch master
- Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master
- Failures on Fedora-x86_64-m64, branch master
- Failures on Fedora-ppc64le-native-gdbserver-m64, branch master
- Failures on Fedora-x86_64-native-gdbserver-m32, branch master
- Failures on Fedora-ppc64le-m64, branch master
- Failures on Debian-i686, branch master
- Failures on Debian-i686-native-gdbserver, branch master
- Failures on Debian-x86_64-m64, branch master
- Failures on Debian-x86_64-native-gdbserver-m64, branch master