This is the mail archive of the gdb-testers@sourceware.cygnus.com mailing list for the GDB project. See the GDB home page for more information.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: gdb4-17.86 build issues on HP-UX 10.20 and 11.0

Mike Vermeulen wrote:
> 
>         2. gdb/remote.c and gdb/target.c mixes C prototypes and old-style
>            functions with parameter types that are not the same when
>            default argument promotions are applied.  This is patch.02 and
>            was also previously reported against 4.17.85.

> *** gdb-4.17.85/gdb/remote.c    Wed Feb  3 09:02:03 1999
> --- gdb-4.17.85.patched/gdb/remote.c    Sat Feb 27 12:00:53 1999
> ***************
> *** 293,299 ****
> 
>   static int stubhex PARAMS ((int ch));
> 
> ! static int remote_query PARAMS ((char, char *, char *, int *));
> 
>   static int hexnumstr PARAMS ((char *, ULONGEST));
> 
> --- 293,299 ----
> 
>   static int stubhex PARAMS ((int ch));
> 
> ! static int remote_query PARAMS ((int, char *, char *, int *));
> 
>   static int hexnumstr PARAMS ((char *, ULONGEST));
> 

Just this isn't sufficient.  The problem is:

Andrew Cagney wrote:
> The thing is that the function remote_query() is assigned to
> `struct target_ops'.to_query.  If we're going to change the signature
> of remote_query() then we'll also need to change to_query() and any other
> uses of it.

Unless Stan (as head maintainer objects).  I'll rip out PARAMS for all
these
offending functions (making them all true ISO-C).

	Andrew