[Bug build/17077] --with-system-readline uses bundled readline include files

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17077

--- Comment #10 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a8a5dbcab8df0b3a9e04745d4fe8d64740acb323

commit a8a5dbcab8df0b3a9e04745d4fe8d64740acb323
Author: Tom Tromey <tom@tromey.com>
Date:   Wed Sep 26 06:54:17 2018 -0600

    Do not accidentally include in-tree readline headers

    PR build/17077 points out that when --with-system-readline is given,
    gdb will still pick up the in-tree readline headers.  Normally this is
    not a big problem, because readline is very stable and so the ABI does
    not change much; but it is clearly a bug to do this, and could bite at
    some point.

    The basic problem is that OPCODES_CFLAGS uses -I$(OPCODES_SRC)/..  so
    that #include "opcodes/..." works.  However, this also makes it so the

    This patch fixes the problem in a mildly hacky way: remove the
    offending -I option, and change gdb to use #include "../opcodes/..."
    instead.  This continues to make it clear where the header comes from,
    without allowing incorrect behavior.

    Tested by rebuilding and then looking at the *.Po files.

    gdb/ChangeLog
    2018-10-06  Tom Tromey  <tom@tromey.com>

        PR build/17077:
        * Makefile.in (OPCODES_CFLAGS): Remove "-I$(OPCODES_SRC)/..".
        * arc-tdep.c, frv-tdep.c, lm32-tdep.c, mep-tdep.c,
        microblaze-tdep.c, or1k-tdep.h: Use ../opcodes, not opcodes, in
        #include.

-- 
You are receiving this mail because:
You are on the CC list for the bug.