This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug varobj/23378] [8.1 -> 8.2 regression] gdb.mi/mi-var-cmd.exp, with gdbserver


https://sourceware.org/bugzilla/show_bug.cgi?id=23378

--- Comment #3 from Joel Brobecker <brobecker at gnat dot com> ---
Looks like this was fixed by the following commit:

commit 4e2aa472847923f94b99f138d7fc4c77796f8239
Author: Simon Marchi <simon.marchi@ericsson.com>
Date:   Wed Aug 22 13:37:05 2018 -0400

    Restore behavior of disabling address randomization by default on GDBserver

    Commit

      c12a508 ("Add client_state struct.")

    inadvertently changed the default behavior of GDBserver wrt address
    randomization.  The old disable_randomization global variable was
    initialized to 1, whereas the corresponding field in the client_state
    structure is initialized to 0.

    This fixes

      make check TESTS="gdb.base/jit-simple.exp"
RUNTESTFLAGS="--target_board=native-gdbserver"
      make check TESTS="gdb.base/execl-update-breakpoints.exp"
RUNTESTFLAGS="--target_board=native-gdbserver"

    Note that the execl-update-breakpoints.exp would only fail on systems
    where the toolchain emits position-independent executables by default
    (otherwise the main executable position is never randomized, so the
    value of disable_randomization didn't matter).

    gdb/gdbserver/ChangeLog:

        PR gdb/23374
        PR gdb/23375
        * server.h (struct client_state) <disable_randomization>:
        Initialize to 1.


Not closing just yet, as I believe we want this commit in the gdb-8.2-branch,
and it looks to me like it is not in yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]