[Bug gdb/18624] GDB on windows with golang: buildsym_init Assertion `free_pendings == NULL` failed.

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=18624

--- Comment #15 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4735f0edf4265e3e260e10a12921baf17987a020

commit 4735f0edf4265e3e260e10a12921baf17987a020
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Jun 29 15:10:04 2018 -0600

    Use scoped_free_pendings in coff_symtab_read

    PR gdb/18624 concerns an assertion failure that occurs when setting a
    breakpoint in a Go program on Windows.

    What happens here is that coff_symtab_read uses buildsym but does not
    instantiate scoped_free_pendings.  So, the struct pending objects are
    never released.  Later, dwarf2read.c calls buildsym_init, which
    asserts.

    This patch fixes the problem by instantiating scoped_free_pendings in
    coff_symtab_read.

    Tested using the test executable from the PR.  I don't know how to
    test this more fully.

    gdb/ChangeLog
    2018-07-17  Tom Tromey  <tom@tromey.com>

        PR gdb/18624:
        * coffread.c (coff_symtab_read): Use scoped_free_pendings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.