[Bug build/18843] New: gdb/procfs.c:4927:3: error: implicit declaration of function ?make_cleanup_close?

["saper at marcincieslak dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=18843

            Bug ID: 18843
           Summary: gdb/procfs.c:4927:3: error: implicit declaration of
                    function ?make_cleanup_close?
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: saper at marcincieslak dot com
  Target Milestone: ---

make[1]: Leaving directory '/home/admini/saper/build/binutils/gdb'
/home/admini/saper/sparcv7/bin/gcc -m64 -mtune=ultrasparc3 -g -O2   -I.
-I/home/admini/saper/src/binutils-gdb/gdb
-I/home/admini/saper/src/binutils-gdb/gdb/common
-I/home/admini/saper/src/binutils-gdb/gdb/config
-DLOCALEDIR="\"/home/admini/saper/sparcv9/share/locale\"" -DHAVE_CONFIG_H
-I/home/admini/saper/src/binutils-gdb/gdb/../include/opcode
-I/home/admini/saper/src/binutils-gdb/gdb/../opcodes/..
-I/home/admini/saper/src/binutils-gdb/gdb/../readline/..
-I/home/admini/saper/src/binutils-gdb/gdb/../zlib -I../bfd
-I/home/admini/saper/src/binutils-gdb/gdb/../bfd
-I/home/admini/saper/src/binutils-gdb/gdb/../include -I../libdecnumber
-I/home/admini/saper/src/binutils-gdb/gdb/../libdecnumber 
-I/home/admini/saper/src/binutils-gdb/gdb/gnulib/import -Ibuild-gnulib/import  
-DTUI=1 -I/home/admini/saper/sparcv9/include   -Wall -Wpointer-arith
-Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts
-Wempty-body -Wpointer-sign -Wmissing-prototypes -Wdeclaration-after-statement
-Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition
-Wformat-nonliteral -Werror -c -o procfs.o -MT procfs.o -MMD -MP -MF
.deps/procfs.Tpo /home/admini/saper/src/binutils-gdb/gdb/procfs.c
/home/admini/saper/src/binutils-gdb/gdb/procfs.c: In function
?iterate_over_mappings?:
/home/admini/saper/src/binutils-gdb/gdb/procfs.c:4927:3: error: implicit
declaration of function ?make_cleanup_close?
[-Werror=implicit-function-declaration]
   make_cleanup_close (map_fd);
   ^
cc1: all warnings being treated as errors


The fix is easy:

diff --git a/gdb/procfs.c b/gdb/procfs.c
index 42f1403..3d4f7be 100644
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -30,6 +30,7 @@
 #include "gdbthread.h"
 #include "regcache.h"
 #include "inf-child.h"
+#include "filestuff.h"

 #if defined (NEW_PROC_API)
 #define _STRUCTURED_PROC 1     /* Should be done by configure script.

-- 
You are receiving this mail because:
You are on the CC list for the bug.