This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug compile/18484] Fix crash on cv-qualified self-reference


https://sourceware.org/bugzilla/show_bug.cgi?id=18484

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Kratochvil <jkratoch@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=084641963dba63283bf2eca227f4f77c2598b172

commit 084641963dba63283bf2eca227f4f77c2598b172
Author: Jan Kratochvil <jan.kratochvil@redhat.com>
Date:   Wed Jul 8 14:42:19 2015 +0200

    compile: Warn for old GCC on cv-qualified self-reference

    GDB could:

    compile code struct_object.selffield = &struct_object
    ./compile/compile-c-types.c:83: internal-error: insert_type: Assertion `add
== NULL || add->gcc_type == gcc_type' failed.
    A problem internal to GDB has been detected,
    further debugging may prove unreliable.
    Quit this debugging session? (y or n) FAIL: gdb.compile/compile.exp:
compile code struct_object.selffield = &struct_object (GDB internal
    error)

    The bug was not in GDB but in the GCC part interfacing with GDB.

    Alexandre Oliva has fixed it the right way:
       
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;a=commitdiff;h=072dfdba0ea62abb65514cb3a90cdf3868efe286
        git://gcc.gnu.org/git/gcc.git
        aoliva/libcp1

    Attaching this GDB testsuite update + info to user s/he should upgrade GCC.
    After Alex upstreams the fix I can update the message to contain the
specific
    GCC release.

    gdb/ChangeLog
    2015-07-08  Jan Kratochvil  <jan.kratochvil@redhat.com>

        PR compile/18484
        * compile/compile-c-types.c (insert_type): Change gdb_assert to error.

    gdb/testsuite/ChangeLog
    2015-07-08  Jan Kratochvil  <jan.kratochvil@redhat.com>

        PR compile/18484
        * gdb.compile/compile.c (struct struct_type): Add volatile to
        selffield's type.
        * gdb.compile/compile.exp
        (compile code struct_object.selffield = &struct_object): Skip further
        struct_object tests if this one xfails.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]