This is the mail archive of the gdb-prs@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug symtab/17564] lookup of static symbols should properly search each objfile in order


https://sourceware.org/bugzilla/show_bug.cgi?id=17564

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  af3768e945b188caa141e3285dc3eb84f440a673 (commit)
      from  c4bfc839ee132ad8f925800410f4b5bb7ff0fb0d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=af3768e945b188caa141e3285dc3eb84f440a673

commit af3768e945b188caa141e3285dc3eb84f440a673
Author: Doug Evans <xdje42@gmail.com>
Date:   Mon Nov 10 15:48:49 2014 -0800

    PR 17564: Fix objfile search order for static symbols.

    When searching static symbols, gdb would search over all
    expanded symtabs of all objfiles, and if that fails only then
    would it search all partial/gdb_index tables of all objfiles.
    This means that the user could get a random instance of the
    symbol depending on what symtabs have been previously expanded.
    Now the search is consistent, searching each objfile completely
    before proceeding to the next one.

    gdb/ChangeLog:

        PR symtab/17564
        * symtab.c (lookup_symbol_in_all_objfiles): Delete.
        (lookup_static_symbol): Move definition to new location and rewrite.
        (lookup_symbol_in_objfile): New function.
        (lookup_symbol_global_iterator_cb): Call it.

    gdb/testsuite/ChangeLog:

        PR symtab/17564
        * gdb.base/symtab-search-order.exp: New file.
        * gdb.base/symtab-search-order.c: New file.
        * gdb.base/symtab-search-order-1.c: New file.
        * gdb.base/symtab-search-order-shlib-1.c: New file.

-----------------------------------------------------------------------

Summary of changes:
 gdb/ChangeLog                                      |    8 ++
 gdb/symtab.c                                       |   97 +++++++++-----------
 gdb/testsuite/ChangeLog                            |    8 ++
 gdb/testsuite/gdb.base/symtab-search-order-1.c     |    1 +
 .../gdb.base/symtab-search-order-shlib-1.c         |    7 ++
 gdb/testsuite/gdb.base/symtab-search-order.c       |   11 ++
 gdb/testsuite/gdb.base/symtab-search-order.exp     |   59 ++++++++++++
 7 files changed, 137 insertions(+), 54 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/symtab-search-order-1.c
 create mode 100644 gdb/testsuite/gdb.base/symtab-search-order-shlib-1.c
 create mode 100644 gdb/testsuite/gdb.base/symtab-search-order.c
 create mode 100644 gdb/testsuite/gdb.base/symtab-search-order.exp

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]