This is the mail archive of the
gdb-prs@sources.redhat.com
mailing list for the GDB project.
cli/1608: "edit" command doesn't put '/' between path and file
- From: kraftche at cae dot wisc dot edu
- To: gdb-gnats at sources dot redhat dot com
- Date: 7 Apr 2004 21:23:24 -0000
- Subject: cli/1608: "edit" command doesn't put '/' between path and file
- Reply-to: kraftche at cae dot wisc dot edu
>Number: 1608
>Category: cli
>Synopsis: "edit" command doesn't put '/' between path and file
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: unassigned
>State: open
>Class: patch
>Submitter-Id: net
>Arrival-Date: Wed Apr 07 21:28:02 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator: kraftche@cae.wisc.edu
>Release: 6.1
>Organization:
>Environment:
Debian GNU/Linux testing/unstable
>Description:
Edit command concatonates path and filename without
seperating them with a '/'. Also, potential buffer
overflow in edit_command() if either the dirname or
filename is NULL.
>How-To-Repeat:
>Fix:
patch attached
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: application/octet-stream; name="edit-bug.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="edit-bug.patch"
LS0tIGdkYi9jbGkvY2xpLWNtZHMuYwkyMDA0LTAyLTI4IDEyOjA0OjM3LjAwMDAwMDAwMCAtMDYw
MAorKysgZ2RiL2NsaS9jbGktY21kcy5jCTIwMDQtMDQtMDcgMTY6MTU6MDEuMDAwMDAwMDAwIC0w
NTAwCkBAIC01NTQsNiArNTU0LDcgQEAKICAgdW5zaWduZWQgbTsKICAgY2hhciAqZWRpdG9yOwog
ICBjaGFyICpwOworICBjaGFyICpkaXJuYW1lOwogCiAgIC8qIFB1bGwgaW4gdGhlIGN1cnJlbnQg
ZGVmYXVsdCBzb3VyY2UgbGluZSBpZiBuZWNlc3NhcnkgKi8KICAgaWYgKGFyZyA9PSAwKQpAQCAt
NjMyLDE3ICs2MzMsMTkgQEAKICAgbG9nMTAgPSAxICsgKGludCkoKGxvZzEwICsgKDAgPT0gKCht
LTEpICYgc2FsLmxpbmUpKSkvMy4zMjE5MjgwOSk7CiAKICAgY21kbGVuID0gc3RybGVuKGVkaXRv
cikgKyAxCi0gICAgICAgICArIChOVUxMID09IHNhbC5zeW10YWItPmRpcm5hbWUgPyAwIDogc3Ry
bGVuKHNhbC5zeW10YWItPmRpcm5hbWUpICsgMSkKLQkgKyAoTlVMTCA9PSBzYWwuc3ltdGFiLT5m
aWxlbmFtZT8gMCA6IHN0cmxlbihzYWwuc3ltdGFiLT5maWxlbmFtZSkrIDEpCisgICAgICAgICsg
KE5VTEwgPT0gc2FsLnN5bXRhYi0+ZGlybmFtZSA/IDIgOiBzdHJsZW4oc2FsLnN5bXRhYi0+ZGly
bmFtZSkgKyAxKQorCSArIChOVUxMID09IHNhbC5zeW10YWItPmZpbGVuYW1lPyA3IDogc3RybGVu
KHNhbC5zeW10YWItPmZpbGVuYW1lKSsgMSkKIAkgKyBsb2cxMCArIDI7CiAgIAogICBwID0geG1h
bGxvYyhjbWRsZW4pOwotICBzcHJpbnRmKHAsIiVzICslZCAlcyVzIixlZGl0b3Isc2FsLmxpbmUs
Ci0gICAgIChOVUxMID09IHNhbC5zeW10YWItPmRpcm5hbWUgPyAiLi8iIDoKLSAgICAgICAgKE5V
TEwgIT0gc2FsLnN5bXRhYi0+ZmlsZW5hbWUgJiYgKihzYWwuc3ltdGFiLT5maWxlbmFtZSkgIT0g
Jy8nKSA/Ci0JICAgc2FsLnN5bXRhYi0+ZGlybmFtZSA6ICIiKSwKLSAgICAgKE5VTEwgPT0gc2Fs
LnN5bXRhYi0+ZmlsZW5hbWUgPyAidW5rbm93biIgOiBzYWwuc3ltdGFiLT5maWxlbmFtZSkKLSAg
KTsKKyAgZGlybmFtZSA9IE5VTEw7CisgIGlmIChOVUxMICE9IHNhbC5zeW10YWItPmZpbGVuYW1l
ICYmICcvJyAhPSAqc2FsLnN5bXRhYi0+ZmlsZW5hbWUpICAKKyAgICBkaXJuYW1lID0gTlVMTCA9
PSBzYWwuc3ltdGFiLT5kaXJuYW1lID8gIi4iIDogc2FsLnN5bXRhYi0+ZGlybmFtZTsKKyAgc3By
aW50ZihwLCIlcyArJWQgJXMlcyVzIiwKKyAgICAgICAgICBlZGl0b3IsIHNhbC5saW5lLAorICAg
ICAgICAgIGRpcm5hbWUgPyBkaXJuYW1lIDogIiIsIAorICAgICAgICAgIGRpcm5hbWUgPyAiLyIg
OiAiIiwKKyAgICAgICAgICBOVUxMID09IHNhbC5zeW10YWItPmZpbGVuYW1lID8gInVua25vd24i
IDogc2FsLnN5bXRhYi0+ZmlsZW5hbWUpOwogICBzaGVsbF9lc2NhcGUocCwgZnJvbV90dHkpOwog
CiAgIHhmcmVlKHApOwo=