This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Factor out the code to do the datadir-relocation for gdbinit
On Wednesday, August 21 2019, Christian Biesinger wrote:
> On Wed, Aug 21, 2019 at 12:47 PM Sergio Durigan Junior
> <sergiodj@redhat.com> wrote:
>>
>> On Wednesday, August 21 2019, Christian Biesinger wrote:
>>
>> > On Wed, Aug 21, 2019 at 12:19 PM Sergio Durigan Junior
>> > <sergiodj@redhat.com> wrote:
>> >>
>> >> On Tuesday, August 20 2019, Christian Biesinger via gdb-patches wrote:
>> >>
>> >> > gdb/ChangeLog:
>> >> >
>> >> > 2019-08-20 Christian Biesinger <cbiesinger@google.com>
>> >> >
>> >> > * main.c (relocate_gdbinit_path_maybe_in_datadir): New function.
>> >> > (get_init_files): Update.
>> >>
>> >> I'm afraid you'll need a descriptive commit message :-).
>> >
>> > Changed to:
>> >
>> > 2019-08-20 Christian Biesinger <cbiesinger@google.com>
>> >
>> > * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
>> > out of get_init_files.
>> > (get_init_files): Update.
>> >
>> > (I guess the title of the commit message is not enough?)
>>
>> Sorry, I should have been more clear.
>>
>> The changelog entry was fine; I was referring to the actual commit
>> message (the text you write before the changelog). I think a very
>> simple text should be enough in this case, since it's a refactorization.
>
> Oh OK, changed to the following:
> Factor out the code to do the datadir-relocation for gdbinit
>
> This simplifies get_init_files and makes it possible to reuse
> this code in an upcoming patch for SYSTEM_GDBINIT_DIR.
>
> gdb/ChangeLog:
>
> 2019-08-20 Christian Biesinger <cbiesinger@google.com>
>
> * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
> out of get_init_files.
> (get_init_files): Update.
>
> (I assume it's fine not to resend the full patch, but let me know if
> you want me to)
That's great, thanks.
I can't approve it as I'm not a GM, but this LGTM.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/