This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host
- From: Simon Marchi <simark at simark dot ca>
- To: Sandra Loosemore <sandra at codesourcery dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 14 Aug 2019 23:12:53 -0400
- Subject: Re: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host
- References: <9bb4446e-8a94-496d-ab8c-6d1197ac0728@codesourcery.com>
On 2019-08-13 6:29 p.m., Sandra Loosemore wrote:
> This is yet another testsuite fix to clean up results on remote Windows
> host.
>
> For this testcase, I did consider trying to fix it rather than just
> disabling it for remote host, but it looked like it was going to be an
> awful lot of work and trial-and-error (it has almost no comments to
> explain what it is trying to test, or how it is getting there). I think
> it is at least an incremental improvement to document that it isn't
> expected to work as-is on remote host. And disabling it does get rid of
> 33 completely bogus FAILs. :-P
>
> OK?
>
> -Sandra
>
> +# This test has hard-wired assumptions that host and build filenames are
> +# the same, and assumes POSIX pathname syntax.
> +if { [is_remote host] || [ishost *-*-mingw*] } {
> + return 0
> +}
> +
Should we use "untested" or "unsupported" before returning, to have at least a status
in the logs? The definition of "unsupported" seems appropriate for this case:
Declares that a test case depends on some facility that does not exist in the
testing environment.
From: https://www.gnu.org/software/dejagnu/manual/unsupported-procedure.html
Simon