This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Simplify write_inferior_memory

From: Kevin Buettner <kevinb at redhat dot com>
To: Tom Tromey <tromey at adacore dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 14 Aug 2019 18:59:32 -0700
Subject: Re: [PATCH 1/2] Simplify write_inferior_memory
References: <20190814164814.29367-1-tromey@adacore.com> <20190814164814.29367-2-tromey@adacore.com>

On Wed, 14 Aug 2019 10:48:13 -0600
Tom Tromey <tromey@adacore.com> wrote:

> gdbserver's write_inferior_memory uses a static variable to avoid
> memory leaks, and has a comment referring to the lack of cleanups.
> This patch removes this comment and the code in favor of a
> straightforward use of std::vector.
> 
> gdb/gdbserver/ChangeLog
> 2019-08-14  Tom Tromey  <tromey@adacore.com>
> 
> 	* target.c (write_inferior_memory): Use std::vector.

LGTM.

Kevin

References:
- [PATCH 0/2] Small memory-writing gdbserver improvements
  - From: Tom Tromey
- [PATCH 1/2] Simplify write_inferior_memory
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]