This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/8] Remove readline hack from gdb_select
On 8/6/19 9:43 PM, Tom Tromey wrote:
> As discussed on gdb-patches, this removes the readline hack from the
> mingw-hdep.c version of gdb_select. It's believed that this is not
> needed any more.
I may be hard to find the discussion later on.
Please add a link to the discussion to the commit log
pointing here:
https://sourceware.org/ml/gdb-patches/2019-03/msg00465.html
Thanks,
Pedro Alves
>
> 2019-08-04 Tom Tromey <tom@tromey.com>
>
> * mingw-hdep.c (gdb_select): Remove readline hack.
> ---
> gdb/ChangeLog | 4 ++++
> gdb/mingw-hdep.c | 9 ---------
> 2 files changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/gdb/mingw-hdep.c b/gdb/mingw-hdep.c
> index 8ed4b44ddce..44fb22e9a16 100644
> --- a/gdb/mingw-hdep.c
> +++ b/gdb/mingw-hdep.c
> @@ -23,7 +23,6 @@
> #include "event-loop.h"
>
> #include "gdb_select.h"
> -#include "readline/readline.h"
>
> #include <windows.h>
>
> @@ -167,14 +166,6 @@ gdb_select (int n, fd_set *readfds, fd_set *writefds, fd_set *exceptfds,
> }
> }
>
> - /* With multi-threaded SIGINT handling, there is a race between the
> - readline signal handler and GDB. It may still be in
> - rl_prep_terminal in another thread. Do not return until it is
> - done; we can check the state here because we never longjmp from
> - signal handlers on Windows. */
> - while (RL_ISSTATE (RL_STATE_SIGHANDLER))
> - Sleep (1);
> -
> return num_ready;
> }
>
>