This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/8] Upgrade readline
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Tue, 6 Aug 2019 20:05:20 -0700
- Subject: Re: [PATCH 0/8] Upgrade readline
- References: <20190806204334.13441-1-tom@tromey.com>
On Tue, 6 Aug 2019 14:43:26 -0600
Tom Tromey <tom@tromey.com> wrote:
> Here's the series to upgrade readline. This has been sitting around
> for a while and I thought I would finally send it.
>
> I built it on a Windows machine at AdaCore, but although readline is
> built and gdb links against it, I can't get it to work. Maybe this is
> due to whatever remote terminal I am using -- I don't know.
>
> Tested on x86-64 Fedora 28. Also, note that the major distros use
> --with-system-readline, which I think is further evidence that this
> works.
>
> This was too big to test on the buildbot.
>
> Let me know what you think.
I glanced at patches 2-5, and 8. For some reason, 1 and 6 haven't
shown up yet. The ones I've looked at look reasonable.
I tried building GDB on one of the BSDs earlier this year, which lacked
an obvious system readline. (It was available, but I either had to
install it or tell configure where it was, maybe both.) In any case,
I had build problems with the in-tree readline. I then tried building
GDB on F29 with system readline disabled and ran into the same
problems. So I'm in favor of anything which fixes that breakage.
So, basically, if it builds, I think it should go in.
Kevin