This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] AArch64: Allow additional sizes in prologue
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Cc: Tom Tromey <tom at tromey dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Tue, 6 Aug 2019 12:18:21 +0000
- Subject: Re: [PATCH] AArch64: Allow additional sizes in prologue
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WRBCQu1AwoQXe1wAqNjzq0cn2WnB+6pj/YKnUeUCwVs=; b=eEuM9XVmbti4qkHWSbwBL55MCTHt8xr1fiGjUtC4T8YuDOJ3jlLAOwuvCo+ECk7xALBtWtFr5MJlu/8cos649A4sTHqe9Zvwp+9GkPhAhQ2wPW5cIWP/OnY+cyZN/Q8P6dOYnA9xpNW2ofu1HTNy0BCGC4pjyw6h2tp6/NRqgrrUqVqbYfKFXPsZnqNb6t7PF+pHBp1qIVsP7mZR1wb8NKOBWZXv4mlVMOooFDUKE6x3H5ix7LtWaFq7l8GJUUEdoAE9ky18I7orQQVHqu+7HqBSC0SMmOlMH6sN3M2MRi/Si7jz/OZL7/NL1us7lup92v26Gl74OZebrn/HSPbl5w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Slz9gIKXfW6wwJxg7XnWHDhd6RNqKAdu3eBsCgrxc5lVXE89tkhpvXySv6/jYXMJ1BytghL61pfNFUyMeQTEqWz8f3IFVBdrtroI9viRwRkYT5qwP2T5gtieKdnntNoCjtzWRdJTNWIv9+2E90hADcFxHUf+DiexeK/iSvS2WWsNh2S3wPkbYDaw4e/0IMDqYTDOfBzuCgZvNtTWh2RK6QlajnxOYBzfr79ySRc1mCYJyCJjHyfSADlS9y6TVPFxgcc40RjlNHXd7SKnv7ou8QfzLZjh+u6vM9MccD1xKZlKZ0Egx6BC2vSg1Qp0b77dOPYQd0haL37OLeJYFlroZw==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan dot Hayward at arm dot com;
- References: <20190805124152.26127-1-alan.hayward@arm.com> <8736ifcxu8.fsf@tromey.com> <16866921-5116-49AE-A00E-9D738CE212BD@arm.com> <793a518d-be9c-75f0-96a5-9acdc90d7a62@arm.com>
> On 6 Aug 2019, at 10:56, Richard Earnshaw (lists) <Richard.Earnshaw@arm.com> wrote:
>
> On 06/08/2019 09:58, Alan Hayward wrote:
>>> On 5 Aug 2019, at 18:43, Tom Tromey <tom@tromey.com> wrote:
>>>
>>>>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:
>>>
>>> Alan> When saving registers to the stack at the start of a function, not all state
>>> Alan> needs to be saved. For example, only the first 64bits of float registers need
>>> Alan> saving. However, a program may choose to store extra state if it wishes,
>>> Alan> there is nothing preventing it doing so.
>>>
>>> Alan> The aarch64_analyze_prologue will error if it detects extra state being
>>> Alan> stored. Relex this restriction.
>>>
>>> I don't know anything about AArch64, so I can't really comment on the
>>> content of the patch, but I did happen to see a nit:
>>>
>>> Alan> stack.store (pv_add_constant (regs[rn],
>>> Alan> inst.operands[1].addr.offset.imm),
>>> Alan> - is64 ? 8 : 4, regs[rt]);
>>> Alan> + size, regs[rt]);
>>>
>>> ...this addition looked mis-indented to me.
>> Thanks.
>> I probably missed that because the correct formatting looks horrible:
>> stack.store (pv_add_constant (regs[rn],
>> inst.operands[1].addr.offset.imm),
>> size, regs[rt]);
>> Instead, I can update it to the following
>> stack.store (
>> pv_add_constant (regs[rn], inst.operands[1].addr.offset.imm),
>> size, regs[rt]);
>
> I think the coding convention in that case is to write:
>
>
> stack.store
> (pv_add_constant (regs[rn], inst.operands[1].addr.offset.imm),
> size, regs[rt]);
>
> R.
Ok, will use that way.
Alan.