This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] AArch64: Allow additional sizes in prologue
- From: Tom Tromey <tom at tromey dot com>
- To: Alan Hayward <Alan dot Hayward at arm dot com>
- Cc: "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Mon, 05 Aug 2019 11:43:11 -0600
- Subject: Re: [PATCH] AArch64: Allow additional sizes in prologue
- References: <20190805124152.26127-1-alan.hayward@arm.com>
>>>>> "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:
Alan> When saving registers to the stack at the start of a function, not all state
Alan> needs to be saved. For example, only the first 64bits of float registers need
Alan> saving. However, a program may choose to store extra state if it wishes,
Alan> there is nothing preventing it doing so.
Alan> The aarch64_analyze_prologue will error if it detects extra state being
Alan> stored. Relex this restriction.
I don't know anything about AArch64, so I can't really comment on the
content of the patch, but I did happen to see a nit:
Alan> stack.store (pv_add_constant (regs[rn],
Alan> inst.operands[1].addr.offset.imm),
Alan> - is64 ? 8 : 4, regs[rt]);
Alan> + size, regs[rt]);
...this addition looked mis-indented to me.
Tom