This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Require GNU make 3.82
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: "gdb-patches\\@sourceware.org" <gdb-patches at sourceware dot org>
- Cc: nd <nd at arm dot com>, Eli Zaretskii <eliz at gnu dot org>
- Date: Thu, 1 Aug 2019 16:09:35 +0000
- Subject: Re: [PATCH] Require GNU make 3.82
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=arm.com;dmarc=pass action=none header.from=arm.com;dkim=pass header.d=arm.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tlrd+o6hpM3Fs1lLfAVWuoSCObI7CsYzNh8Q9wbVLis=; b=W0VdQ9EN1KzYVyhkOcei8jVPVVz0aKFVkmOwkr05owwBYRVqIJtlI6Zl8e7OC07NP9K790GnzhGD3u7S8vzcH+jxFukIGYk+fFDNfM23WTTv3D1OufNreS8nw+asAavxz/kTlul7VAYF5Yt5lC2hzbQRm31gvJZzF7AWb5w+YtkwD36nSGQrKmbsU2VRpVvGXFwxBC1xyqvgve67ep9J5gimSxjzm/hqKEEf8viqJ0Qze4n7HK8p8ysJfYhIQd57XTliTO1U9osQyIhSzj1t/FtxKZQ9AhduT+WYnwioyIGIeaVfXQgg5/1orj4H1AmoYp/kFcLbUK2qZTMaLoqKRQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XBCDqJ+JrF130vRVSl+lbYhG721BefJvgMayjV0d3H8iKvBK7nTgilFLLHSPoFZwrqULmUtix7R7zfmHTYQZeeA66Bt1Jqzz8GSRF2kjE5q2+y3XWipHeP0lmlfZgQnNdoLl6EQbIbUakS70IhsVinpYOuqUCfSCpBT2OAJ7S04BMlou301UujyU3VIGo/UkfMJ0a1trYQtPu1FTeSDr8FxmwL66a2vuCFH8mJGT5oiRizkjpEI90DuTfvAYF7f+7MwBxrYK12hMivUrp7JvC4KwbXtCHz7JdmDJ5MJSs4UZvyFEsCt1yKEMU/lxwBS+GNNFyvSShbqWdgT5Pn57ag==
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan dot Hayward at arm dot com;
- References: <20190715101124.77677-1-alan.hayward@arm.com> <83v9vzyih8.fsf@gnu.org> <1298B553-A75A-4D06-9AC4-4F924B045C16@arm.com>
I pushed this patch.
> On 18 Jul 2019, at 11:57, Alan Hayward <Alan.Hayward@arm.com> wrote:
>
>
>
>> On 18 Jul 2019, at 07:17, Eli Zaretskii <eliz@gnu.org> wrote:
>>
>>> From: Alan Hayward <Alan.Hayward@arm.com>
>>> CC: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com>
>>> Date: Mon, 15 Jul 2019 10:11:29 +0000
>>>
>>> Gdbserver has failed to build with GNU make 3.81 since commit 08f10e02be.
>>
>> Which feature of Make 3.82 and later is required to successfully
>> build gdbserver?
>>
>
> It’s not a specific feature in 3.82 that is required.
>
> It looks like it is a bug in 3.81. The GDB makefile isn’t doing anything special
> and everything works using 3.82 upwards.
>
> Rewriting the makefile to work around the issue is probably going to be a little
> messy.
>
>
>>> diff --git a/gdb/NEWS b/gdb/NEWS
>>> index 4e479bf738..3a92b24e44 100644
>>> --- a/gdb/NEWS
>>> +++ b/gdb/NEWS
>>> @@ -251,6 +251,11 @@ maint show test-options-completion-result
>>> GDB) in the output directory for each test script. Multiple invocations
>>> are appended with .1, .2, .3 etc.
>>>
>>> +* Building GDB and GDBserver now requires GNU make >= 3.82.
>>> +
>>> + Using another implementation of the make program or an earlier version of
>>> + GNU make to build GDB or GDBserver is not supported.
>>> +
>>
>> The test is OK, thanks.
>
> Thanks!
>
> Alan.