This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use block_enum instead of int for better typesafety

From: Tom Tromey <tom at tromey dot com>
To: "Christian Biesinger via gdb-patches" <gdb-patches at sourceware dot org>
Cc: Christian Biesinger <cbiesinger at google dot com>
Date: Fri, 19 Jul 2019 07:54:21 -0600
Subject: Re: [PATCH] Use block_enum instead of int for better typesafety
References: <20190711183827.242710-1-cbiesinger@google.com> <20190711184045.244858-1-cbiesinger@google.com>

>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> 2019-07-11  Christian Biesinger  <cbiesinger@google.com>

Christian> 	* symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
Christian> 	(lookup_symbol_in_objfile): Change int to block_enum and add a
Christian> 	gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.

Thanks, this is ok.  Please check it in.

Tom

Follow-Ups:
- Re: [PATCH] Use block_enum instead of int for better typesafety
  - From: Christian Biesinger via gdb-patches

References:
- [PATCH] Use block_enum instead of int for better typesafety
  - From: Christian Biesinger via gdb-patches
- [PATCH] Use block_enum instead of int for better typesafety
  - From: Christian Biesinger via gdb-patches

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]