This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PING][PATCH] Fix amd64->i386 linux syscall restart problem
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: gdb-patches at sourceware dot org, Pedro Alves <palves at redhat dot com>
- Date: Fri, 12 Jul 2019 05:23:49 -0700
- Subject: Re: [PING][PATCH] Fix amd64->i386 linux syscall restart problem
- References: <20190316221341.021f7c62@f29-4.lan> <975e7120-1b61-2807-5aab-b961e07a80d0@redhat.com> <20190409192916.79fcb539@f29-4.lan> <bc353e59-f640-2d09-8a71-984f0102733e@redhat.com> <20190410171606.0e736077@f29-4.lan> <40eb20c2-f6d0-eb16-d6fe-c717138b6559@suse.de> <c8913564-b950-6091-0d17-04938953367a@suse.de> <20190708100001.6f2bc0fc@f29-4.lan> <54a90435-e80e-6028-1007-db4423669850@suse.de>
Hi Tom,
Yes, that's right, those two commits are needed. I've looked it over. It
looks good to me.
Kevin
On Fri, 12 Jul 2019 13:42:51 +0200
Tom de Vries <tdevries@suse.de> wrote:
> On 08-07-19 19:00, Kevin Buettner wrote:
> >
> > On Fri, 21 Jun 2019 08:34:46 +0200
> > Tom de Vries <tdevries@suse.de> wrote:
> >
> >> On 21-05-19 14:59, Tom de Vries wrote:
> >>> On 11-04-19 02:16, Kevin Buettner wrote:
> >>>> On Wed, 10 Apr 2019 12:42:30 +0100
> >>>> Pedro Alves <palves@redhat.com> wrote:
> >>>>
> >>>>>> Below is a diff showing the new comments. It also includes the
> >>>>>> changes which wrap the multi-line expressions in parens.
> >>>>>
> >>>>> Thanks, that new version of the comment looks great.
> >>>>
> >>>> It's in now. Thanks for the review.
> >>>
> >>> Hi,
> >>>
> >>> the tests fixed by this commit fail on the 8.3 branch (filed as PR24592).
> >>>
> >>> The commit applies cleanly on the 8.3 branch, and make the tests pass.
> >>>
> >>> OK to backport?
> >>
> >> Hi,
> >>
> >> [ Ping. ]
> >>
> >> I'm probably missing some context here. It seems sofar there are no
> >> commits to the 8.3 branch. AFAIU, a respin release 8.3.1 is targeted for
> >> 3 months after 8.3, so around 11th of August.
> >>
> >> What kind of fixes are acceptable for the respin? Do they have to be
> >> regression fixes? Or are functionality fixes like this one also allowed?
> >> Who's responsibility is it to backport fixes?
> >>
> >> Thanks,
> >> - Tom
> >
> > I'm okay with it going into the next point release for 8.3.
>
> Hi Kevin,
>
> I noticed the follow-up commit e90a813d96 "Fix regression caused by
> recently added syscall restart code". I reproduced the regression with
> the 8.3 branch + commit 3f52fdbcb5, and confirmed that the follow-up
> commit fixes it, so I suppose this one is necessary as well.
>
> Since this is the first time I'm pushing something to a gdb release
> branch, I'm posting here the two pre-commit-formatted patches for review.
>
> Thanks,
> - Tom
>
>