This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] gdb: Allow quoting around string options in the gdb::option framework


* Tom Tromey <tom@tromey.com> [2019-07-11 10:17:43 -0600]:

> >>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
> 
> Andrew>  proc expect_string {str operand} {
> Andrew> +    # Dequote the string in the expected output.
> Andrew> +    if { ( [string range $str 0 0] == "\"" && [string range $str end end] == "\"") \
> Andrew> +	     || ([string range $str 0 0] == "'" && [string range $str end end] == "'")} {
> 
> These lines look over-long.
> Also the trailing "\" isn't needed here.

Pushed with this fix.

Thanks,
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]