Re: [PATCH 3/7] Arm: Add read_description read funcs and use in GDB

[Simon Marchi <simark at simark dot ca>]

On 2019-07-10 10:26 a.m., Alan Hayward wrote:
>>> If it doesn't make sense to have this function shared with GDBserver (given
>>> that GDBserver doesn't run on Cortex-Ms), it should probably go in gdb/arm-tdep.c.
>>
>> Right. I wasn’t thinking of arch as “architecture code shared with gdbserver”,
>> but it makes sense.
>>
>> The GDBSERVER defines do vanish later in the series.
>>
>> I think I preferred having the two functions together in arch, but I’ve moved it.
>>
> 
> To this, I’ll add that moving the mprofile function into arm-tdep.c means that
> in a later patch, both arm-tdep.c and arch/arm.c have to 
> #include "features/arm/arm-vfpv2.c”
> 
> This is because ARM_M_TYPE_VFP_D16 uses the vfpv2 functions.
> 
> It works, but means that the same static function is being included twice.
> 
> 
> Alan.

Ok, well I agree that the end result looks ok, it's not a big deal if there is a function in
arch/arm.h that only gdb uses.  It's true that it also makes sense to keep these functions
together.  I was just a bit put off by the "#ifndef GDBSERVER" initially.

Simon