This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCHv2 5/5] gdb: Better support for dynamic properties with negative values
- From: Tom Tromey <tom at tromey dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Wed, 10 Jul 2019 09:02:56 -0600
- Subject: Re: [PATCHv2 5/5] gdb: Better support for dynamic properties with negative values
- References: <cover.1557439866.git.andrew.burgess@embecosm.com> <672dc208d6dfb9f068eb635e02bf85abb9630c74.1557439866.git.andrew.burgess@embecosm.com> <87lfyycn6i.fsf@tromey.com> <20190610221701.GO23204@embecosm.com>
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
I meant to reply to this but forgot to. I'm sorry about that.
>> I wonder whether this should be using ULONGEST rather than CORE_ADDR
>> now.
Andrew> I don't think you're wrong, but I'm hoping I can convince you to let
Andrew> me punt this change for now, it would be fairly big change to the
Andrew> dwarf property fetching code. What we have seems to hang together for
Andrew> now, so I'd prefer to get this change in first.
Yes, I think it's fine to just move forward with the patch you've
written.
Tom