This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] Update breakpoint_1's documentation

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: gdb-patches at sourceware dot org
Date: Wed, 10 Jul 2019 08:29:45 -0600
Subject: Re: [PATCH 2/2] Update breakpoint_1's documentation
References: <20190710015135.28368-1-simon.marchi@polymtl.ca> <20190710015135.28368-2-simon.marchi@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> I noticed the documentation of breakpoint_1 way way out of date, so this
Simon> is an attempt to update it.  I have changed the parameter names to
Simon> something that seems clearer to me.

Simon> gdb/ChangeLog:

Simon> 	* breakpoint.c (breakpoint_1): Update doc and parameter names.

This seems good to me.  Thanks for doing this.

Simon>  	      int (*filter) (const struct breakpoint *))

I guess someday the filter could return bool as well.

Tom

Follow-Ups:
- Re: [PATCH 2/2] Update breakpoint_1's documentation
  - From: Simon Marchi

References:
- [PATCH 1/2] Make some bpstat functions use bool
  - From: Simon Marchi
- [PATCH 2/2] Update breakpoint_1's documentation
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]