This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] "catch catch/throw/rethrow", breakpoint -> catchpoint


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro>  (gdb) maint info breakpoints  
Pedro>  Num     Type           Disp Enb Address            What
Pedro>  2       catchpoint     keep y                      exception catch
Pedro>  2.1                         y   0x000000000040545f <__cxa_begin_catch+95> inf 1
Pedro>  2.2                         y   0x00007ffff71dbe0f <__cxxabiv1::__cxa_begin_catch(void*)+95> inf 1
Pedro>  (gdb)

Pedro> WDYT?

This looks great to me.

Pedro> Note: I considered making the locations be printed from within
Pedro> breakpoint_ops::print_one(), but gave up given the handling
Pedro> for the broken MI v2 output:

Pedro>  /* The mi2 broken format: the main breakpoint tuple ends here, the locations
Pedro>      are outside.  */
Pedro>   if (!use_fixed_output)
Pedro>     bkpt_tuple_emitter.reset ();

Pedro> in print_one_breakpoint.

Ouch.  It would be nice if we could find a way to make the backward
compatibility hacks not impact the main code.  Like, hacks in
mi/something.c somewhere instead would be preferable.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]