Re: [PATCH 1/3] i386/AArch64: Remove old xml tests

[Kevin Buettner <kevinb at redhat dot com>]

On Mon, 1 Jul 2019 11:15:56 +0000
Alan Hayward <Alan.Hayward@arm.com> wrote:

> Both the i386, X86_64 and AArch64 builds of gdbserver include a bunch of legacy
> xml files, dat files and auto generated C files, when building for unit test.
> 
> These tests exist back from when feature target descriptions were added to
> prove that the new target descriptions were identical to the original
> older versions. The old files are not used for anything other than these tests.
> 
> Now that this has been proven, we are not gaining anything by keeping the
> original files and tests. Should new functionality be added, it would break
> the tests, unless the functionality was backported to the xml. There is no
> requirement that we must match the exact xml from N releases ago.  It adds
> obfuscation, where as the feature target descriptions were meant to simplify
> the code.
> 
> In addition, there are a bunch of xml and dat files which are completely unused.
> 
> This patch removes the selftests and the target descriptions from gdbserver.
> 
> Update the unittest to allow 0 tests (note, this failed on other targets that
> never had any tests).
> 
> 2019-07-01  Alan Hayward  <alan.hayward@arm.com>
> 
> 	* configure.srv: Remove legacy xml.
> 	* linux-aarch64-low.c (initialize_low_arch): Remove
> 	initialize_low_tdesc call.
> 	* linux-aarch64-tdesc-selftest.c: Remove file.
> 	* linux-aarch64-tdesc.h (initialize_low_tdesc): Remove.
> 	* linux-x86-low.c (initialize_low_arch): Remove
> 	initialize_low_tdesc call.
> 	* linux-x86-tdesc-selftest.c: Remove file.
> 	* linux-x86-tdesc.h (initialize_low_tdesc): Remove.
> 
> gdb/testsuite/ChangeLog:
> 
> 2019-07-01  Alan Hayward  <alan.hayward@arm.com>
> 
> 	* gdb.server/unittest.exp: Allow 0 unit tests to run.

This patch, and the follow on patches too, look good to me.

Kevin