This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Move generic_load declaration to symfile.h


On 2019-07-01 9:03 a.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> ... since the implementation is in symfile.c.
> Simon> At the same time, add some documentation and make sure the first
> Simon> parameter's name in the declaration matches the definition.
> 
> Simon> gdb/ChangeLog:
> 
> Simon> 	* defs.h (generic_load): Move from here...
> Simon> 	* symfile.h (generic_load): ... to here.  Rename name parameter
> Simon> 	to args.
> Simon> 	* symfile.c (generic_load): Add comment.
> 
> Thanks, this looks good to me.  I'm generally in favor of shrinking
> defs.h and of having the .h reflect the .c.
> 
> Tom
> 

Thanks, I have pushed it.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]