This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output)
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 01 Jul 2019 11:20:25 -0600
- Subject: Re: ui_out format strings for fields and styles (Re: [PATCH] Style "pwd" output)
- References: <20190605020116.1550-1-tom@tromey.com> <1ee4bd6b-4cdf-f3a9-74af-0843bf123a8b@redhat.com> <87lfygi1x0.fsf@tromey.com> <32872d6a-15d6-9718-59ae-957694e114c9@redhat.com> <b0299d9c-22d8-de30-72b5-99de4605d5dd@redhat.com> <87imtjhj6b.fsf@tromey.com> <625cd0ba-058d-d4bf-8ba3-8676f335b0f3@redhat.com> <87blzbep47.fsf@tromey.com> <2180f72f-da10-5333-90a1-666ba3bd145e@redhat.com> <87imtjbrmx.fsf@tromey.com> <871s056yjw.fsf@tromey.com> <db55b7f1-4ebd-806b-2d70-c382a2c40a3f@redhat.com> <87ef3aq6ux.fsf@tromey.com> <5372d765-b75f-8d2c-bf0f-e3c0ddc3a802@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> The visual balance of brackets is appealing as well, so I can't say
Pedro> I have a strong preference either way. If you've been converting things
Pedro> already, you'll have a better judgment, so I'll defer to you.
I haven't really converted much, just what you saw on the branch.
I suspect using some kind of paired brackets will make it a little
harder to forget to close the style. But probably only a little. Also
I guess we could add asserts to check that the closing parameter is
always null.
Pedro> If we went the always-%pS way, I had written the patch and it'd
Pedro> look like this:
This is fine by me too.
Tom