Re: [PATCH] Use new Darwin operating system names

[Saagar Jha <saagar at saagarjha dot com>]

Here’s a new patch with the changes you’ve asked for. Let me know if you need anything else!

Saagar Jha

Attachment: Use-new-Darwin-operating-system-names.patch
Description: Binary data

> On Feb 15, 2019, at 02:02, Nick Clifton <nickc@redhat.com> wrote:
> 
> Hi Saagar,
> 
>> 
>> 1) This entry should go in include/ChangeLog, so you don't need to
>> have the include/ prefix.
>> 
>> 2) Please adjust it to indicate that only the comments are affected. 
>> Like this, perhaps:
>> 
>> 	* mach-o/loader.h: Use new OS names in comments.
>> 
>> Otherwise, it looks good to me.
>> 
>> I wish I could tell you to check this in, but I think that the
>> binutils maintainers will need to approve this change.  I've added
>> binutils@sourceware.org to the "To:" header in my reply.
> 
> It is fine with the binutils too.  So please apply with the changes
> that Kevin has outlined.
> 
> Cheers
>  Nick
> 
>