This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0/6] change range adapters to be member functions


>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On patches #1 and #2, I'd rather drop the "all_" from the method
Pedro> names, to follow the pattern in the inferiors/threads ranges, where
Pedro> we have:
[...]

I made this change.

Pedro> On patch #5 the commit log says:
Pedro>  "array_view is nearly usable, except that this iterator
Pedro>   must return pointers rather than references."
Pedro> I found that "must" intriguing.  It's not that it
Pedro> must -- with array_view, we could still write code like this:
[...]
Pedro> So I think it'd be fitting to update the commit log to replace
Pedro> the "must" with "more convenient" or something like it.  Maybe
Pedro> even add a comment to the code.

I reworded the commit message.

I've re-run this through the buildbot, and I'm going to push it soon.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]