This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, RFC] fix gdbserver channel leaks
- From: Tom Tromey <tom at tromey dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>
- Date: Thu, 17 Jan 2019 09:02:15 -0700
- Subject: Re: [PATCH, RFC] fix gdbserver channel leaks
- References: <15b31a68-82f4-b9e9-7b9a-d9a82f8903d9@codesourcery.com>
>>>>> "Sandra" == Sandra Loosemore <sandra@codesourcery.com> writes:
Sandra> I've thought it best to consolidate the logic to manage
Sandra> server_spawn_id in start_gdbserver and close_gdbserver. It did seem
Sandra> plausible to put the logic to shut down any old server_spawn_id
Sandra> channel before opening a new one in gdbserver_run instead of in
Sandra> start_gdbserver, but there are places that bypass that function (e.g.,
Sandra> in the mi test support).
FWIW this patch looks reasonable to me.
Sandra> I'm wondering, can other people who do remote-target gdbserver testing
Sandra> help try out this patch and see if it works for them?
I can't really help with that, though, I'm afraid.
Tom