Re: [PATCH] Simulator: prevent inlining in C++ mode

[Pedro Alves <palves at redhat dot com>]

On 01/17/2019 09:53 AM, Alan Hayward wrote:
> 
>> On 16 Jan 2019, at 19:51, Simon Marchi <simon.marchi@polymtl.ca> wrote:
>>
>> On 2019-01-16 13:29, Pavel I. Kryukov wrote:
>>> Okay, there are no C++ compiler errors other than macro expansion,
>>> so this patch may be ignored. I submitted a separate patch for macros
>>> expansion (https://sourceware.org/ml/gdb-patches/2019-01/msg00367.html)
>>
>> I'll take a look.
>>
>>> (Sorry, I still get lines wrapped in patches while sending them via Gmail.
>>> Could you please tell if there is a workaround?)
>>
>> The best way is to use "git-send-email".  You will need an SMTP server, whether it is gmail, your ISP's, etc.  This should help:
>>
>> https://coderwall.com/p/dp-gka/setting-up-git-send-email-with-gmail
>>
>> If you really can't get this to work, the next best thing is to generate a .patch file (git format-patch HEAD^) and send it as an attachment.  This ensures that the formatting is preserved.
>>
> 
> As someone who suffered similar issues until I moved to git send-mail, I’m
> wondering if it’s worth it adding to the "Submitting Patches” section in
> the CONTRIBUTE file?  I can have a go at writing that if it makes sense.

That will be good, no denying that.  Thanks in advance.

Though I think it'd be even better to fix the longstanding CONTRIBUTE
problem.  I.e., replace the current gdb/CONTRIBUTE file's contents, with a
pointer to:

 https://sourceware.org/gdb/contribute/

and then have that point to some wiki page instead of at gdb/CONTRIBUTE.

Wiki pages are much easier to update to keep up with the processes, which
are not tied to a specific gdb version.  Also, web content can take advantage
of cross linking.

Note that:

 https://sourceware.org/gdb/wiki/ContributionChecklist#Submitting_patches

also has information about git send-email and how to set up various clients.

Thanks,
Pedro Alves