This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Fix leaks in macro definitions.

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>, gdb-patches at sourceware dot org
Date: Tue, 15 Jan 2019 12:49:04 -0500
Subject: Re: [RFA] Fix leaks in macro definitions.
References: <20190115055611.17967-1-philippe.waroquiers@skynet.be> <63b6768fbedbe46b7a46f0d29f7b178c@polymtl.ca> <87h8e9on9h.fsf@tromey.com>

On 2019-01-15 12:15, Tom Tromey wrote:

"Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:


Simon> Would you consider that a bug in the splay tree implementation?
Simon> Should it use the new key and free the old one with the key
Simon> deallocation function?

Yes, I would think so as well, given that we pass key- and
value-deletion functions to splay_tree_new_with_allocator.

Ok. Fixing this in the splay tree code would be a quite long task(reviewing all usages in binutils-gdb and gcc, I don't think this codeis available externally?), so I am ok with this patch which fixes theissue in the mean time. Tom?


Simon

Follow-Ups:
- Re: [RFA] Fix leaks in macro definitions.
  - From: Tom Tromey

References:
- [RFA] Fix leaks in macro definitions.
  - From: Philippe Waroquiers
- Re: [RFA] Fix leaks in macro definitions.
  - From: Simon Marchi
- Re: [RFA] Fix leaks in macro definitions.
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]