This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Oh dear. I regret to inform you that commit 053af8c9034f92d6e36a1180655ba22a65c56437 might be unfortunate


On 2019-01-07 11:16, Simon Marchi wrote:
On 2019-01-07 08:26, gdb-buildbot@sergiodj.net wrote:
My lords, ladies, gentlemen, members of the public.

It is a matter of great regret and sadness to inform you that commit:

	Sync libiberty sources with master version in gcc repository.
Updated stabs demangling and cxxfilt tests to match.
	053af8c9034f92d6e36a1180655ba22a65c56437

might have made GDB unwell.  Since I am just your Butler BuildBot,
I kindly ask that a human superior officer double-check this.

Please note that if you are reading this message on gdb-patches, there might
be other builders broken.

You can find more details about the unfortunate breakage in the next messages.

Cheers,

Your GDB BuildBot.

Hi Nick,

As you can see, GDB needs to be adjusted to stop using
cplus_demangle_opname (it was expected [1]).  It shouldn't be too
difficult to do, but I would prefer not to rush it (take the time to
test it, get it reviewed).  Would you mind reverting this patch, just
the time we adjust the GDB code?

Thanks,

Simon

[1] https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01160.html

I ended up reverting this patch to unbreak the build. I'll try to update the GDB code shortly to unblock it (or if somebody else is motived, I don't mind).

When re-syncing the code with GCC, note that there are corresponding changes to include/demangle.h that should be imported too.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]