This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Remove a cleanup from target-descriptions.c

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 02 Jan 2019 15:40:04 -0500
Subject: Re: [PATCH] Remove a cleanup from target-descriptions.c
References: <20190102155243.17250-1-tom@tromey.com>

On 2019-01-02 10:52, Tom Tromey wrote:

This removes a cleanup from target-descriptions.c, by changing it to
use a unique_ptr instead.  Note that a deletion adapter is used, even
though target_desc is allocated with new, to avoid moving target_desc
to target-descriptions.h.

Just wondering, is there something preventing the target_desc structurefrom going to target-descriptions.h?


The patch LGTM in any case.

Simon

Follow-Ups:
- Re: [PATCH] Remove a cleanup from target-descriptions.c
  - From: Tom Tromey

References:
- [PATCH] Remove a cleanup from target-descriptions.c
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]