This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb/testsuite/sim: Remove redundant setting of timeout


On 12/04/2018 09:34 PM, Andrew Burgess wrote:

> Thanks both for the feedback.
> 
> In the end I went for (a) - making timeout global, backing it up, etc
> just to print a log message seemed like overkill, especially when we
> adjust the timeout in lots of other places without any logging at all.
> 
> With the logging gone, folding the timeout into the gdb_expect call
> seemed like an obvious cleanup.
> 
> The new patch is below.
> 

Fine with me.

> As having log messages about the timeout being adjusted could cause
> confusion I've removed all logging related to timeouts in this
> function, timeouts are adjusted thoughout the testsuite without any

Typo: "throughout"

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]