This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [gdb/testsuite] Add gdb-caching-proc.exp testcase
- From: Tom de Vries <tdevries at suse dot de>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Sat, 1 Dec 2018 09:04:15 +0100
- Subject: Re: [gdb/testsuite] Add gdb-caching-proc.exp testcase
- References: <20181004174015.GA20307@delia> <dafc5935-4ae1-cd79-5adb-7cb13dd23aa5@redhat.com> <20181009134747.GA1742@delia> <87tvjymjli.fsf@tromey.com>
On 30-11-18 20:49, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> 2018-10-09 Tom de Vries <tdevries@suse.de>
> Tom> * gdb.base/gdb-caching-proc.exp: New file.
>
> Thanks for the patch. I didn't see a review or see this go in, so
> hopefully this isn't redundant.
>
Hi Tom,
indeed this was not reviewed yet.
> Tom> +# Test gdb_caching_proc NAME
> Tom> +proc test_proc { name } {
> Tom> + set real_name gdb_real__$name
> Tom> +
> Tom> + set first [$real_name]
> Tom> + lappend resultlist $first
>
> I think this lappend is unnecessary...
>
> Tom> + set resultlist [list]
>
> ... because resultlist is reset here.
> But maybe you intended to hoist this earlier?
Yep, I did, fixed in the commit.
> Either way is fine by me.
>
> This is ok with this nit addressed.
Thanks for the review.
- Tom