This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Introduce dwarf2_cu::get_builder
- From: Tom Tromey <tom at tromey dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 30 Nov 2018 13:32:32 -0700
- Subject: Re: [PATCH] Introduce dwarf2_cu::get_builder
- References: <20181126230855.27040-1-keiths@redhat.com>
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
I just noticed this version...
Keith> +private:
Keith> /* The symtab builder for this CU. This is only non-NULL when full
Keith> symbols are being read. */
Keith> - std::unique_ptr<buildsym_compunit> builder;
Keith> + std::unique_ptr<buildsym_compunit> m_builder;
Good idea, thanks for doing this.
I think the previous nits still apply; though this email didn't include
the test so I don't know for certain about those.
thanks,
Tom