This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFAv2 2/2] Test case for 'info variables|functions' with minimal symbols.

From: Tom Tromey <tom at tromey dot com>
To: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
Cc: gdb-patches at sourceware dot org
Date: Mon, 19 Nov 2018 15:11:19 -0700
Subject: Re: [RFAv2 2/2] Test case for 'info variables|functions' with minimal symbols.
References: <20181110150048.21031-1-philippe.waroquiers@skynet.be> <20181110150048.21031-3-philippe.waroquiers@skynet.be>

>>>>> "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:

Philippe> 2018-11-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
Philippe> 	* gdb.base/info_minsym.c: New file.
Philippe> 	* gdb.base/info_minsym.exp: New file.

...

Philippe> +gdb_test_no_output "info variables -q -t int minsym" "minsym variables do not match type"
Philippe> +gdb_test_no_output "info functions -q -t int minsym" "minsym functions do not match type"

I think these lines are too long and should be split.
Otherwise the patch is ok.

Tom

Follow-Ups:
- Re: [RFAv2 2/2] Test case for 'info variables|functions' with minimal symbols.
  - From: Philippe Waroquiers

References:
- [RFAv2 0/2] Fix regression 'info variables' does not show minimal symbols.
  - From: Philippe Waroquiers
- [RFAv2 2/2] Test case for 'info variables|functions' with minimal symbols.
  - From: Philippe Waroquiers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]