This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Move copy_bitwise unittests to own unittest file

From: Pedro Alves <palves at redhat dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Thu, 15 Nov 2018 10:59:08 +0000
Subject: Re: [RFA] Move copy_bitwise unittests to own unittest file
References: <20181024162037.21024-1-tom@tromey.com> <20181101153517.GA2705@adacore.com> <082f66ea-223b-52f4-bc24-b274dbcf4f01@redhat.com> <609409e6-235a-4724-3ced-57c3ff42e299@redhat.com> <20181109171641.GD18647@adacore.com> <20181114171116.GA6074@adacore.com> <7628ab26-ad93-726c-f1d4-d5c60492115c@redhat.com> <20181114231724.GA4336@adacore.com> <20181115000158.GC4336@adacore.com>

On 11/15/2018 12:01 AM, Joel Brobecker wrote:

> Here it is:
> 
> gdb/ChangeLog:
> 
>         * unittests/copy_bitwise-selftests.c: New file.
>         * utils.c (selftests::bits_to_str, selftests::check_copy_bitwise)
>         (selftests::copy_bitwise_tests): Delete, moving this code to
>         unittests/copy_bitwise-selftests.c instead.
>         (_initialize_utils): Do not register copy_bitwise tests.
>         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
>         unittests/copy_bitwise-selftests.c.
> 
> Tested on x86_64-linux using the official testsuite, but also by
> verifying that "maintenance selftests" still runs the copy_bitwise
> tests.
> 
> OK to push to master?
> 

OK.

> Thank you!
Thanks,
Pedro Alves

Follow-Ups:
- pushed: [RFA] Move copy_bitwise unittests to own unittest file
  - From: Joel Brobecker

References:
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Joel Brobecker
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Pedro Alves
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Pedro Alves
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Joel Brobecker
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Joel Brobecker
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Pedro Alves
- Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits
  - From: Joel Brobecker
- [RFA] Move copy_bitwise unittests to own unittest file (was: "Re: [PATCH] Fix buffer overflow in ada-lang.c:move_bits")
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]