This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Avoid crash when calling warning too early
- From: Tom Tromey <tom at tromey dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Thu, 08 Nov 2018 16:10:06 -0700
- Subject: Re: [PATCH v2] Avoid crash when calling warning too early
- References: <20181031181820.24308-1-tom@tromey.com> <875zxi9csd.fsf@redhat.com> <87y3adn9o8.fsf@tromey.com> <87r2g597kb.fsf@redhat.com>
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>> If you want, I can just drop this and you can take over.
Sergio> Thanks, but I'd prefer if you checked your patch in. The bug reported
Sergio> on 23555 is actually composed of two issues: (a) what to do when GDB
Sergio> can't determine the CWD, and (b) the segmentation fault that happens
Sergio> when we try to call warning too early in the code. Your patch fixes
Sergio> (b), and I still didn't sit down to figure out how to approach (a). So
Sergio> it's best if we just go ahead and avoid the segfault for now.
I'm going to check it in now, with the ChangeLog change you suggested.
Tom