This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][gdb/symtab] Fix language of duplicate static minimal symbol
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 07 Nov 2018 10:23:54 -0500
- Subject: Re: [PATCH][gdb/symtab] Fix language of duplicate static minimal symbol
- References: <20181030191142.GA13785@delia> <07e42727-0d74-7f04-ef7c-39e180f71da8@redhat.com> <b5867027-cc84-47fe-353e-6bbbb0ce96ea@suse.de>
On 2018-10-31 05:09, Tom de Vries wrote:
I have a pre-commit script (for both gcc and gdb) that uses this
format,
and puts ChangeLog hunks in the correct ChangeLog file ( more detail
here: https://sourceware.org/ml/gdb-patches/2018-06/msg00351.html ).
Sofar this format has been acceptable for maintainers.
Yes, as long as they end up in the right file it's fine.
The patch LGTM too. Before, pushing could you just add a one liner
description in your .exp file? Something like:
# Test that when two symbols with the same linkage name are present in
the
# executable, they both get assigned the right language.
Thanks,
Simon