This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 2018-10-16 13:07, Tom de Vries wrote:
On 10/16/18 12:11 AM, Simon Marchi wrote:On 2018-10-11 03:47, Tom de Vries wrote:[gdb/testsuite] Rewrite catch-follow-exec.expMy build of GDB (and probably some on the buildbot too?) uses -fsanitize=address, and on it the test does not pass. On a build without -fsanitize=address, it does pass. The failing test is: FAIL: gdb.base/catch-follow-exec.exp: [lindex $result 3] == 1 and the value of $result is "17872 exp10 0 23". This is because ASan exits with 23 if it detects leaks.I had trouble reproducing this, until I tried -fsanitize=leak.If there's a way to set LSAN_OPTIONS='exitcode=1' in the environment GDB runs in, it would probably make it work...I've fixed this by changing the test from == 1 to != 0.
Ah, good.
+if { [target_info gdb_protocol] != "" } { + unsupported "not native"Please add a comment here, something like:# Even though the feature under features being tested are supported bygdbserver,# the way this test is written doesn't make it easy with a remote target.Done.+ gdb_test_multiple "" "run til exit" { + "runtime error:" { + # Error in case of --enable-ubsan + fail "No runtime error" + }Please use a lower case letter for the test name.Done. OK for trunk?
LGTM, thanks! Simon
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |