This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [SPAM] Re: [PATCH 0/8] Add -Wshadow=local
Hi Tom,
>>>>>> "Rainer" == Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
>
> Rainer> this patch series broke the Solaris builds:
>
> Rainer> ../../binutils-gdb/gdb/sol-thread.c: In member function ‘virtual ptid_t sol_thread_target::wait(ptid_t, target_waitstatus*, int)’:
> Rainer> ../../binutils-gdb/gdb/sol-thread.c:443:14: error: declaration of ‘save_ptid’ shadows a previous local [-Werror=shadow=compatible-local]
> Rainer> ptid_t save_ptid = ptid;
> Rainer> ^~~~~~~~~
> Rainer> ../../binutils-gdb/gdb/sol-thread.c:432:10: note: shadowed declaration is here
> Rainer> ptid_t save_ptid;
> Rainer> ^~~~~~~~~
>
> Thanks for the report.
>
> If you can try the appended, that would be nice. If not, I will check
> it in, since it looks reasonably obviously correct.
I just tested the patch on amd64-pc-solaris2.11 (-m64 only): nothing
more than the usual testsuite variations due to racy tests. Thanks.
> Normally I would ask the buildbot to try it but I get:
>
> bapiya. buildbot try -b Solaris11-amd64-m64
>
> === ERROR: You probably have an invalid builder in the list of Try Builders ===
> === Please, double-check the list of available builders at ===
> === <https://sourceware.org/gdb/wiki/BuildBot#Configuration_file_for_.22buildbot_try.22> ===
>
> ... which seems incorrect to me.
This is weird indeed: I've changed nothing on the buildslaves, am pretty
certain that I saw runs of the Try scheduler from you before, and this
must be a buildmaster error anyway.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University