This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 7/8] Shadowing fix in gdbscm_frame_read_var
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: Tom Tromey <tom at tromey dot com>, "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>
- Date: Thu, 04 Oct 2018 06:43:56 -0600
- Subject: Re: [PATCH 7/8] Shadowing fix in gdbscm_frame_read_var
- References: <20180923040814.27941-1-tom@tromey.com> <20180923040814.27941-8-tom@tromey.com> <6d098a36-c483-77b8-61a6-87768c29f5d5@ericsson.com>
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
Simon> On 2018-09-23 12:08 AM, Tom Tromey wrote:
>> -Wshadow=local pointed out that the shadowing in gdbscm_frame_read_var
>> means that the ultimate call to read_var_value will always be passed
>> block==NULL. The fix is to remove the outer declaration.
Simon> s/outer/inner/ ?
Yes, thanks. I've updated the commit message.
Tom