This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Don't check HAVE_UNISTD_H
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 01 Oct 2018 09:33:15 -0600
- Subject: Re: [PATCH] Don't check HAVE_UNISTD_H
- References: <20180926113141.21219-1-tom@tromey.com> <16c73f13334db79a79336131b423d1ca@polymtl.ca>
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> LGTM. Maybe we could even remove all includes of unistd.h except the
Simon> one in defs.h, since defs.h is known to be included first in every
Simon> source file. But they are harmless so it's probably not worth the
Simon> effort.
Alternatively we could get rid of the one in defs.h and try to have
headers include what they use. I'm not sure which is better really.
Anyway, I agree that it all seems relatively harmless, so I didn't make
any changes here.
Tom