This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC 4/6] Use mkostemp, not mkstemp

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simark at simark dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sat, 29 Sep 2018 06:49:02 -0600
Subject: Re: [RFC 4/6] Use mkostemp, not mkstemp
References: <20180926111130.18956-1-tom@tromey.com> <20180926111130.18956-5-tom@tromey.com> <2b6097b6-5ffd-6531-4e58-06e1ca62b3d8@simark.ca>

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> On 2018-09-26 7:11 a.m., Tom Tromey wrote:
>> I noticed that gdb could leak file descriptors coming from mkstemp.
>> This patch fixes the problem by importing the gnulib mkostemp instead,
>> and then changing gdb to pass O_CLOEXEC.

Simon> While this looks like the correct thing to do, I am curious to know if
Simon> you encountered an actual issue or this is theoretical.  I don't see
Simon> how a fork/exec could happen while one of these temp files are open.

It can happen if there is a Python or Guile thread that fork+execs.
It seems like it would be hard to observe, but on the other hand, fixing
it seems pretty easy.

Tom

Follow-Ups:
- Re: [RFC 4/6] Use mkostemp, not mkstemp
  - From: Simon Marchi

References:
- [RFC 0/6] A different approach to startup-with-shell on macOS
  - From: Tom Tromey
- [RFC 4/6] Use mkostemp, not mkstemp
  - From: Tom Tromey
- Re: [RFC 4/6] Use mkostemp, not mkstemp
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]