This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Also recognize __sighndlr on Solaris/x86
- From: Simon Marchi <simark at simark dot ca>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>, gdb-patches at sourceware dot org
- Date: Sun, 23 Sep 2018 12:03:54 -0400
- Subject: Re: [PATCH] Also recognize __sighndlr on Solaris/x86
- References: <yddzhwdhci3.fsf@CeBiTec.Uni-Bielefeld.DE>
On 2018-09-19 8:56 a.m., Rainer Orth wrote:
> Unlike Solaris/SPARC, the __sighndlr function isn't recognized as part
> of a signal handler, causing a couple of testcases to fail.
>
> The following patch fixes that. A followup patch will move this to
> common code to avoid such unnecessary discrepancies between
> Solaris/SPARC and x86 in the future.
>
> While this fixes a couple of backtraces to now correctly print
>
> #1 <signal handler called>
>
> they often fail later with
>
> #2 0x0ff3ffffff00857f in ?? ()
> Backtrace stopped: Cannot access memory at address 0xff3000002e0886f
>
> which needs further investigation.
>
> Tested on amd64-pc-solaris2.11 (running the tests with both -m64 and
> -m32). Ok for master?
>
> Rainer
>
I noticed this had not been replied to, this LGTM. I don't know much about
Solaris, but I trust that you know what you are talking about :) and this
looks pretty straightforward.
Simon