This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Carry the gnulib getcwd backport as a patch
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: "gdb-patches\@sourceware.org" <gdb-patches at sourceware dot org>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Tue, 18 Sep 2018 15:38:47 -0600
- Subject: Re: [PATCH] Carry the gnulib getcwd backport as a patch
- References: <20180918212124.5851-1-simon.marchi@ericsson.com>
>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
Simon> Instead, I suggest we carry that backport as a patch applied by the
Simon> update-gnulib.sh script after running the import tool. It will make it
Simon> clear what backport or local modification we have and should make
Simon> running update-gnulib.sh give a reproducible result.
This seems like a good idea to me.
Simon> +# Apply our local patches.
Simon> +apply_patches ()
This should probably be "apply_patch" since it just applies a single patch.
Also there is a comment near the top of update-gnulib.sh:
# This script will also make a number of other verifications:
# . The gnulib version (it should match $GNULIB_COMMIT_SHA1).
# . The correct versions of the auto-tools that are used to
# regenerate the various scripts and Makefiles are on the PATH.
I think an addition here about updating the patches would be good.
Tom