This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Expect for "@" when doing "complete break ada" on gdb.ada/complete.exp
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Tue, 18 Sep 2018 13:51:24 -0400
- Subject: Re: [PATCH] Expect for "@" when doing "complete break ada" on gdb.ada/complete.exp
- References: <20180917213334.4468-1-sergiodj@redhat.com> <20180918150327.GK19172@adacore.com>
On Tuesday, September 18 2018, Joel Brobecker wrote:
> Hi Sergio,
Hey Joel,
> Thanks for the patch!
My pleasure :-).
>> Currently, gdb.ada/complete.exp's "complete break ada" test fails
>> because the regexp used to match the command's output doesn't expect
>> "@", but we have an output like:
>>
>> ...
>> complete break ada
>> break ada.assertions.assert
>> break ada.calendar.arithmetic.difference
>> break ada.calendar.arithmetic_operations.add
>> break ada.calendar.arithmetic_operations.add.cold
>> break ada.calendar.arithmetic_operations.add@plt
>> break ada.calendar.arithmetic_operations.difference
>> break ada.calendar.arithmetic_operations.difference@plt
>> ...
>>
>> This patch adds "@" to the regexp, unbreaking the test.
>>
>> OK?
>>
>> gdb/testsuite/ChangeLog:
>> 2018-09-17 Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * gdb.ada/complete.exp: Expect for "@" when doing "complete
>> break ada".
>
> I can see this behavior, but only when I link with the shared
> version of libgnat. For us at least, on x86_64-linux, this is not
> the default. That's probably why I wasn't seeing this.
Ah, I see. TBH, I haven't investigate this further. I'm glad you can
reproduce it there.
> This is OK.
Thanks, pushed.
7a6d2b458f95030f433a0dcdabd5cda7ee695a9b
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/